Remove deprecated escapeidentifier and unescapeidentifier functions #25333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Jul 2, 2018
|
Please add a note in https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes |
mhegazy
added
Breaking Change
|
@weswigham looks like this is more break-y than we originally thought.. see https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/399575834?utm_source=github_status&utm_medium=notification. Can you revert the change? |
Merged
9 tasks
|
@mhegazy How about I add them back but mark them |
|
I think we are better off filing bugs against current users, then removing them once they have moved away from them. |
|
This is the fix for the current user: ajafff/tsutils#66 - every single error in that build originates in |
cbjuan
added a commit
to Qiskit/qiskit-code-assistant-vscode
that referenced
this pull request
Aug 2, 2018
In general it seems to work as expected. The only issue found is that some functions have been removed from TS (microsoft/TypeScript#25333) Still, the tests pass and the extension runs as usual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since they're noops.
escapeLeadingUnderscoresandunescapeLeadingUnderscoreshave been the typesafe non-noop variants for a few releases now.